# HG changeset patch # User Sebastien Decugis # Date 1370226513 -28800 # Node ID 83d55d26ae80c33852eb5ccd176466f0ee889e7a # Parent 5dab72369dfff32857b5535cfd5561ca7f998f15 Hand the case of invalid objects in the msg_dump functions diff -r 5dab72369dff -r 83d55d26ae80 libfdproto/messages.c --- a/libfdproto/messages.c Mon Jun 03 10:01:31 2013 +0800 +++ b/libfdproto/messages.c Mon Jun 03 10:28:33 2013 +0800 @@ -736,6 +736,11 @@ { FD_DUMP_HANDLE_OFFSET(); + if (!VALIDATE_OBJ(obj)) { + CHECK_MALLOC_DO( fd_dump_extend( FD_DUMP_STD_PARAMS, "INVALID MESSAGE OR AVP @%p"), return NULL); + return *buf; + } + if (force_parsing) { (void) fd_msg_parse_dict(obj, dict, NULL); } @@ -751,6 +756,9 @@ default: ASSERT(0); + free(*buf): + *buf = NULL; + return NULL; } if (recurse) {