# HG changeset patch # User Sebastien Decugis # Date 1378253671 -7200 # Node ID 0b4abb03bcaf7ca43715e0de0cf21b40d2ce9882 # Parent 9e92fa478c2308d02f5a1ef69ea43b20c6be3822 Fix double increment when realloc resulting in invalid SQL query diff -r 9e92fa478c23 -r 0b4abb03bcaf extensions/app_acct/acct_db.c --- a/extensions/app_acct/acct_db.c Sun Aug 11 11:52:36 2013 +0200 +++ b/extensions/app_acct/acct_db.c Wed Sep 04 02:14:31 2013 +0200 @@ -174,7 +174,8 @@ ADD_EXTEND("\") VALUES ("); if (acct_config->tsfield) { - ADD_EXTEND("$%d, ", ++idx); + ++idx; + ADD_EXTEND("$%d, ", idx); } if (acct_config->srvnfield) { ADD_EXTEND("'"); @@ -184,7 +185,8 @@ for (li = emptyrecords.all.next; li != &emptyrecords.all; li = li->next) { struct acct_record_item * i = (struct acct_record_item *)(li->o); - ADD_EXTEND("$%d::%s", ++idx, diam2db_types_mapping[i->param->avptype]); + ++idx; + ADD_EXTEND("$%d::%s", idx, diam2db_types_mapping[i->param->avptype]); if (li->next != &emptyrecords.all) { ADD_EXTEND(", ");