# HG changeset patch
# User Luke Mewburn <luke@mewburn.net>
# Date 1587170871 -36000
# Node ID 195f3fe9b4ed8b1cf0c279ad116da62b16253b14
# Parent  7f7a7cc2ce1f3bfbe187dcb8726a681cd1595964
Fix type of 3GPP HSS-ID (3325)

Note: 3GPP TS 29.338 table 6.3.3.1/1 row HSS-ID (3325)
incorrectly lists type as OctetString instead of UTF8String.
3GPP TS 29.338 clause 6.3.3.14 uses UTF8String.
Fix: HSS-ID (3325) type changed from OctetString to UTF8String.

diff -r 7f7a7cc2ce1f -r 195f3fe9b4ed extensions/dict_dcca_3gpp/add_avps.c
--- a/extensions/dict_dcca_3gpp/add_avps.c	Sat Apr 18 10:20:07 2020 +1000
+++ b/extensions/dict_dcca_3gpp/add_avps.c	Sat Apr 18 10:47:51 2020 +1000
@@ -13293,7 +13293,12 @@
 		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
 	};
 
-	/* HSS-ID, OctetString, code 3325, section 6.3.3.14                 */
+	/* Note: 3GPP TS 29.338 table 6.3.3.1/1 row HSS-ID (3325)           */
+	/* incorrectly lists type as OctetString instead of UTF8String.     */
+	/* 3GPP TS 29.338 clause 6.3.3.14 uses UTF8String.                  */
+	/*                                                                  */
+	/* Fix: HSS-ID (3325) type changed from OctetString to UTF8String.  */
+	/* HSS-ID, UTF8String, code 3325, section 6.3.3.14                  */
 	{
 		struct dict_avp_data data = {
 			3325,	/* Code */
@@ -13303,7 +13308,7 @@
 			AVP_FLAG_VENDOR,	/* Fixed flag values */
 			AVP_TYPE_OCTETSTRING	/* base type of data */
 		};
-		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
+		CHECK_dict_new(DICT_AVP, &data, UTF8String_type, NULL);
 	};
 
 	/* Originating-SIP-URI, UTF8String, code 3326, section 6.3.3.15     */
diff -r 7f7a7cc2ce1f -r 195f3fe9b4ed extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv
--- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Sat Apr 18 10:20:07 2020 +1000
+++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Sat Apr 18 10:47:51 2020 +1000
@@ -1546,7 +1546,12 @@
 SM-Delivery-Timer,3306,6.3.3.10,Unsigned32,"M, V",,,
 SM-Delivery-Start-Time,3307,6.3.3.11,Time,"M, V",,,
 SMSMI-Correlation-ID,3324,6.3.3.13,Grouped,V,,,M
-HSS-ID,3325,6.3.3.14,OctetString,V,,,M
+# Note: 3GPP TS 29.338 table 6.3.3.1/1 row HSS-ID (3325),,,,,,,
+# incorrectly lists type as OctetString instead of UTF8String.,,,,,,,
+# 3GPP TS 29.338 clause 6.3.3.14 uses UTF8String.,,,,,,,
+# ,,,,,,,
+# Fix: HSS-ID (3325) type changed from OctetString to UTF8String.,,,,,,,
+HSS-ID,3325,6.3.3.14,UTF8String,V,,,M
 Originating-SIP-URI,3326,6.3.3.15,UTF8String,V,,,M
 Destination-SIP-URI,3327,6.3.3.16,UTF8String,V,,,M
 OFR-Flags,3328,6.3.3.12,Unsigned32,V,,,M