# HG changeset patch # User Luke Mewburn # Date 1587183988 -36000 # Node ID 3908b839dcf2d229e44446a8a5bb6726671089ff # Parent 12055ddd83187e999fe24d65c13b6e8aed0484b3 Rename Assistance-info and MIC-Check-Indicator 3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802) incorrect name and should be "Assistance-Info" per clause 6.3.3. Fix: Assistance-info (3802) renamed to Assistance-Info (3802). 3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has incorrect name and should be "MIC-Check-Indicator" per clause 6.3.80. Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865). diff -r 12055ddd8318 -r 3908b839dcf2 extensions/dict_dcca_3gpp/add_avps.c --- a/extensions/dict_dcca_3gpp/add_avps.c Sat Apr 18 13:35:46 2020 +1000 +++ b/extensions/dict_dcca_3gpp/add_avps.c Sat Apr 18 14:26:28 2020 +1000 @@ -13759,12 +13759,16 @@ CHECK_dict_new(DICT_AVP, &data, UTF8String_type, NULL); }; - /* Assistance-info, Grouped, code 3802, section 6.3.3 */ + /* Note: 3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802) has */ + /* incorrect name and should be "Assistance-Info" per clause 6.3.3. */ + /* */ + /* Fix: Assistance-info (3802) renamed to Assistance-Info (3802). */ + /* Assistance-Info, Grouped, code 3802, section 6.3.3 */ { struct dict_avp_data data = { 3802, /* Code */ 10415, /* Vendor */ - "Assistance-info", /* Name */ + "Assistance-Info", /* Name */ AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY, /* Fixed flags */ AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY, /* Fixed flag values */ AVP_TYPE_GROUPED /* base type of data */ @@ -14584,12 +14588,16 @@ CHECK_dict_new(DICT_AVP, &data, NULL, NULL); }; - /* MIC-Check-indicator, Unsigned32, code 3865, section 6.3.80 */ + /* Note: 3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has */ + /* incorrect name and should be "MIC-Check-Indicator" per clause 6.3.80. */ + /* */ + /* Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865). */ + /* MIC-Check-Indicator, Unsigned32, code 3865, section 6.3.80 */ { struct dict_avp_data data = { 3865, /* Code */ 10415, /* Vendor */ - "MIC-Check-indicator", /* Name */ + "MIC-Check-Indicator", /* Name */ AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY, /* Fixed flags */ AVP_FLAG_VENDOR, /* Fixed flag values */ AVP_TYPE_UNSIGNED32 /* base type of data */ diff -r 12055ddd8318 -r 3908b839dcf2 extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv --- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv Sat Apr 18 13:35:46 2020 +1000 +++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv Sat Apr 18 14:26:28 2020 +1000 @@ -1648,7 +1648,11 @@ #=,,,,,,, #,,,,,,, App-Layer-User-Id,3801,6.3.2,UTF8String,"M, V",,, -Assistance-info,3802,6.3.3,Grouped,"M, V",,, +# Note: 3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802) has,,,,,,, +"# incorrect name and should be ""Assistance-Info"" per clause 6.3.3.",,,,,,, +# ,,,,,,, +# Fix: Assistance-info (3802) renamed to Assistance-Info (3802).,,,,,,, +Assistance-Info,3802,6.3.3,Grouped,"M, V",,, Assistance-Info-Validity-Timer,3803,6.3.4,Unsigned32,"M, V",,, Discovery-Type,3804,6.3.5,Unsigned32,"M, V",,, Filter-Id,3805,6.3.9,OctetString,"M, V",,, @@ -1714,7 +1718,11 @@ DUSK,3862,6.3.77,OctetString,V,,,M DUIK,3863,6.3.78,OctetString,V,,,M DUCK,3864,6.3.79,OctetString,V,,,M -MIC-Check-indicator,3865,6.3.80,Unsigned32,V,,,M +# Note: 3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has,,,,,,, +"# incorrect name and should be ""MIC-Check-Indicator"" per clause 6.3.80.",,,,,,, +# ,,,,,,, +# Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865).,,,,,,, +MIC-Check-Indicator,3865,6.3.80,Unsigned32,V,,,M Encrypted-Bitmask,3866,6.3.81,OctetString,V,,,M ProSe-App-Code-Suffix-Range,3867,6.3.82,OctetString,V,,,M PC5-tech,3868,6.3.84,OctetString,V,,,M