# HG changeset patch # User Sebastien Decugis # Date 1360677452 -3600 # Node ID 46f9982b7d26c7f5eb2281b5f6b6b1935286f91d # Parent a2cf598607e6a57519a3cafbc92619ac416e3191 Use logging routines for configuration file parsing (based on patch by Thomas) diff -r a2cf598607e6 -r 46f9982b7d26 libfdcore/fdd.l --- a/libfdcore/fdd.l Wed Feb 06 15:52:34 2013 +0100 +++ b/libfdcore/fdd.l Tue Feb 12 14:57:32 2013 +0100 @@ -51,7 +51,7 @@ #define YY_USER_ACTION { \ yylloc->first_column = yylloc->last_column + 1; \ yylloc->last_column = yylloc->first_column + yyleng - 1; \ - TRACE_DEBUG(FULL, \ + TRACE_DEBUG_ERROR( \ "(%d:%d-%d:%d) matched rule %d, length=%d, txt='%s'\n", \ yylloc->first_line, yylloc->first_column, \ yylloc->last_line, yylloc->last_column, \ @@ -103,7 +103,7 @@ int ret = sscanf(yytext, "%i", &yylval->integer); if (ret != 1) { /* No matching: an error occurred */ - fprintf(stderr, "Unable to convert the value '%s' to a valid number: %s\n", yytext, strerror(errno)); + TRACE_DEBUG_ERROR("Unable to convert the value '%s' to a valid number: %s\n", yytext, strerror(errno)); return LEX_ERROR; /* trig an error in yacc parser */ /* Maybe we could REJECT instead of failing here? */ } @@ -145,8 +145,8 @@ /* Unrecognized token */ <*>[[:alnum:]]+ | /* This rule is only useful to print a complete token in error messages */ /* Unrecognized character */ -<*>. { - fprintf(stderr, "Unrecognized text on line %d col %d: '%s'.\n", yylloc->first_line, yylloc->first_column, yytext); +<*>. { + TRACE_DEBUG_ERROR("Unrecognized text on line %d col %d: '%s'.\n", yylloc->first_line, yylloc->first_column, yytext); return LEX_ERROR; } diff -r a2cf598607e6 -r 46f9982b7d26 libfdcore/fdd.y --- a/libfdcore/fdd.y Wed Feb 06 15:52:34 2013 +0100 +++ b/libfdcore/fdd.y Tue Feb 12 14:57:32 2013 +0100 @@ -61,12 +61,13 @@ /* Function to report error */ void yyerror (YYLTYPE *ploc, struct fd_config * conf, char const *s) { - if (ploc->first_line != ploc->last_line) - fprintf(stderr, "%s:%d.%d-%d.%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, ploc->last_line, ploc->last_column, s); - else if (ploc->first_column != ploc->last_column) - fprintf(stderr, "%s:%d.%d-%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, ploc->last_column, s); - else - fprintf(stderr, "%s:%d.%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, s); + if (ploc->first_line != ploc->last_line) { + TRACE_DEBUG_ERROR("%s:%d.%d-%d.%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, ploc->last_line, ploc->last_column, s); + } else if (ploc->first_column != ploc->last_column) { + TRACE_DEBUG_ERROR("%s:%d.%d-%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, ploc->last_column, s); + } else { + TRACE_DEBUG_ERROR("%s:%d.%d : %s\n", conf->cnf_file, ploc->first_line, ploc->first_column, s); + } } int got_peer_noip = 0; @@ -326,7 +327,7 @@ } if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open extension file %s for reading: %s\n", fname, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open extension file %s for reading: %s\n", fname, strerror(ret)); yyerror (&yylloc, conf, "Error adding extension"); YYERROR; } @@ -500,7 +501,7 @@ fd = fopen($3, "r"); if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open certificate file %s for reading: %s\n", $3, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open certificate file %s for reading: %s\n", $3, strerror(ret)); yyerror (&yylloc, conf, "Error on file name"); YYERROR; } @@ -508,7 +509,7 @@ fd = fopen($5, "r"); if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open private key file %s for reading: %s\n", $5, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open private key file %s for reading: %s\n", $5, strerror(ret)); yyerror (&yylloc, conf, "Error on file name"); YYERROR; } @@ -531,7 +532,7 @@ fd = fopen($3, "rb"); if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open CA file %s for reading: %s\n", $3, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open CA file %s for reading: %s\n", $3, strerror(ret)); yyerror (&yylloc, conf, "Error on file name"); YYERROR; } @@ -571,7 +572,7 @@ fd = fopen($3, "rb"); if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open CRL file %s for reading: %s\n", $3, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open CRL file %s for reading: %s\n", $3, strerror(ret)); yyerror (&yylloc, conf, "Error on file name"); YYERROR; } @@ -614,7 +615,7 @@ conf->cnf_sec_data.prio_string, &err_pos), { yyerror (&yylloc, conf, "Error setting Priority parameter."); - fprintf(stderr, "Error at position : %s\n", err_pos); + TRACE_DEBUG_ERROR("Error at position : %s\n", err_pos); YYERROR; } ); } ; @@ -631,7 +632,7 @@ fd = fopen($3, "r"); if (fd == NULL) { int ret = errno; - TRACE_DEBUG(INFO, "Unable to open DH file %s for reading: %s\n", $3, strerror(ret)); + TRACE_DEBUG_ERROR("Unable to open DH file %s for reading: %s\n", $3, strerror(ret)); yyerror (&yylloc, conf, "Error on file name"); YYERROR; }