# HG changeset patch
# User Luke Mewburn <luke@mewburn.net>
# Date 1587169207 -36000
# Node ID 7f7a7cc2ce1f3bfbe187dcb8726a681cd1595964
# Parent  fa7874f2bfeeb754222f62137d435f2846a4fe71
Fix types of 3GPP Max-PLR-DL, Max-PLR-UL

3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852)
incorrectly lists type as Unsigned32 instead of Float32.
3GPP TS 29.212 clause 5.3.138 uses Float32.
Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.

3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853)
incorrectly lists type as Unsigned32 instead of Float32.
3GPP TS 29.212 clause 5.3.139 uses Float32.
Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.

diff -r fa7874f2bfee -r 7f7a7cc2ce1f extensions/dict_dcca_3gpp/add_avps.c
--- a/extensions/dict_dcca_3gpp/add_avps.c	Fri Apr 17 14:21:55 2020 +1000
+++ b/extensions/dict_dcca_3gpp/add_avps.c	Sat Apr 18 10:20:07 2020 +1000
@@ -4003,7 +4003,12 @@
 		CHECK_dict_new(DICT_AVP, &data, type, NULL);
 	};
 
-	/* Max-PLR-DL, Float32, code 2852, section 5.3.138                  */
+	/* Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852)         */
+	/* incorrectly lists type as Unsigned32 instead of Float32.         */
+	/* 3GPP TS 29.212 clause 5.3.138 uses Float32.                      */
+	/*                                                                  */
+	/* Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.  */
+	/* Max-PLR-DL, Unsigned32, code 2852, section 5.3.138               */
 	{
 		struct dict_avp_data data = {
 			2852,	/* Code */
@@ -4011,12 +4016,17 @@
 			"Max-PLR-DL",	/* Name */
 			AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,	/* Fixed flags */
 			AVP_FLAG_VENDOR,	/* Fixed flag values */
-			AVP_TYPE_FLOAT32	/* base type of data */
-		};
-		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
-	};
-
-	/* Max-PLR-UL, Float32, code 2853, section 5.3.139                  */
+			AVP_TYPE_UNSIGNED32	/* base type of data */
+		};
+		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
+	};
+
+	/* Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853)         */
+	/* incorrectly lists type as Unsigned32 instead of Float32.         */
+	/* 3GPP TS 29.212 clause 5.3.139 uses Float32.                      */
+	/*                                                                  */
+	/* Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.  */
+	/* Max-PLR-UL, Unsigned32, code 2853, section 5.3.139               */
 	{
 		struct dict_avp_data data = {
 			2853,	/* Code */
@@ -4024,7 +4034,7 @@
 			"Max-PLR-UL",	/* Name */
 			AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,	/* Fixed flags */
 			AVP_FLAG_VENDOR,	/* Fixed flag values */
-			AVP_TYPE_FLOAT32	/* base type of data */
+			AVP_TYPE_UNSIGNED32	/* base type of data */
 		};
 		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
 	};
diff -r fa7874f2bfee -r 7f7a7cc2ce1f extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv
--- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Fri Apr 17 14:21:55 2020 +1000
+++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Sat Apr 18 10:20:07 2020 +1000
@@ -537,8 +537,18 @@
 HeNB-Local-IP-Address,2804,5.3.95,Address,V,P,,M
 IP-CAN-Session-Charging-Scope,2827,5.3.114,Enumerated,V,P,,M
 IP-CAN-Type,1027,5.3.27,Enumerated,"M,V",P,,
-Max-PLR-DL,2852,5.3.138,Float32,V,P,,M
-Max-PLR-UL,2853,5.3.139,Float32,V,P,,M
+# Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852),,,,,,,
+# incorrectly lists type as Unsigned32 instead of Float32.,,,,,,,
+# 3GPP TS 29.212 clause 5.3.138 uses Float32.,,,,,,,
+# ,,,,,,,
+# Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.,,,,,,,
+Max-PLR-DL,2852,5.3.138,Unsigned32,V,P,,M
+# Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853),,,,,,,
+# incorrectly lists type as Unsigned32 instead of Float32.,,,,,,,
+# 3GPP TS 29.212 clause 5.3.139 uses Float32.,,,,,,,
+# ,,,,,,,
+# Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.,,,,,,,
+Max-PLR-UL,2853,5.3.139,Unsigned32,V,P,,M
 Metering-Method,1007,5.3.8,Enumerated,"M,V",P,,
 Monitoring-Flags,2828,5.3.115,Unsigned32,V,,,M
 Monitoring-Key,1066,5.3.59,OctetString,V,P,,M