# HG changeset patch
# User Luke Mewburn <luke@mewburn.net>
# Date 1585198338 -39600
# Node ID 900d11ff9d172e5db46a34d58cccab110db56226
# Parent  8232878f292d27357ef2b553e4a5364dbf6a36d9
Update to 3GPP2 X.S0057-0 v2.0

Define 3GPP2-BSID (vendor 5535, code 9010) in dict_dcca_3gpp.csv
per 3GPP2 X.S0057-0 v2.0.

Note: Type changed from OctetString to UTF8String.
Note: Must Flag M set.

Generate AVP instead of hand-coding.

diff -r 8232878f292d -r 900d11ff9d17 extensions/dict_dcca_3gpp/dict_dcca_3gpp.c
--- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.c	Thu Mar 26 15:31:54 2020 +1100
+++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.c	Thu Mar 26 15:52:18 2020 +1100
@@ -14782,22 +14782,27 @@
 	};
 
 	/*==================================================================*/
-	/* End of generated data.                                           */
-	/*==================================================================*/
-
-	/* 3GPP2-BSID */
+	/* 3GPP2 X.S0057-0 v2.0                                             */
+	/* From 3GPP2 X.S0057-0_v2.0_091215.pdf                             */
+	/*==================================================================*/
+
+	/* Note: 3GPP2-BSID (9010) corrected from OctetString to UTF8String. */
+	/* 3GPP2-BSID, UTF8String, code 9010, section 5.6.2.1.1             */
 	{
 		struct dict_avp_data data = {
 			9010,	/* Code */
 			5535,	/* Vendor */
 			"3GPP2-BSID",	/* Name */
 			AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,	/* Fixed flags */
-			AVP_FLAG_VENDOR,	/* Fixed flag values */
-			AVP_TYPE_OCTETSTRING	/* base type of data */ /* XXX: guessed */
-		};
-		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
-	};
-
+			AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,	/* Fixed flag values */
+			AVP_TYPE_OCTETSTRING	/* base type of data */
+		};
+		CHECK_dict_new(DICT_AVP, &data, UTF8String_type, NULL);
+	};
+
+	/*==================================================================*/
+	/* End of generated data.                                           */
+	/*==================================================================*/
 
 	/*==================================================================*/
 	/* Rules section                                                    */
diff -r 8232878f292d -r 900d11ff9d17 extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv
--- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Thu Mar 26 15:31:54 2020 +1100
+++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv	Thu Mar 26 15:52:18 2020 +1100
@@ -1,4 +1,4 @@
-Attribute Name,AVP Code,Section defined,Value Type,Must,May,Should not,Must not,May Encrypt
+Attribute Name,AVP Code,Section defined,Value Type,Must,May,Should not,Must not,extra rows
 @vendor,10415,,,,,,,
 ,,,,,,,,
 @standard,3GPP TS 29.061,,,,,,,
@@ -1288,3 +1288,15 @@
 Service-Generic-Information,1256,8.5.10,Grouped,"M,V",,,,Y
 Total-Number-Of-Messages-Exploded,2113,8.4,Unsigned32,"M,V",,,,Y
 Total-Number-Of-Messages-Sent,2114,8.4,Unsigned32,"M,V",,,,Y
+,,,,,,,,
+,,,,,,,,
+@vendor,5535,,,,,,,
+,,,,,,,,
+@standard,X.S0057-0,,,,,,,
+#=,,,,,,,,
+# 3GPP2 X.S0057-0 v2.0,,,,,,,,
+# From 3GPP2 X.S0057-0_v2.0_091215.pdf,,,,,,,,
+#=,,,,,,,,
+#,,,,,,,,
+# Note: 3GPP2-BSID (9010) corrected from OctetString to UTF8String.,,,,,,,,
+3GPP2-BSID,9010,5.6.2.1.1,UTF8String,"M,V",P,,,No