# HG changeset patch
# User Luke Mewburn <luke@mewburn.net>
# Date 1582781268 -39600
# Node ID ca7ca55e2488b2cdc0d6838afcc748df1372268f
# Parent  915450ee91c7a1858e61a680504d6820503bcded
app_sip: debug log a non-NULL value

Detected by gcc 9.1.1.

diff -r 915450ee91c7 -r ca7ca55e2488 extensions/app_sip/TODO
--- a/extensions/app_sip/TODO	Thu Feb 27 16:19:24 2020 +1100
+++ b/extensions/app_sip/TODO	Thu Feb 27 16:27:48 2020 +1100
@@ -49,6 +49,10 @@
 * add mutex on mysql writing
 * check multithreading of mysql!
 * get destination host in database for RTR and PPR
+* libapp_sip.c: fix username_pure memory leaks
+* app_sip_MAR_cb:
+  - too much mysql_real_escape_string() use, both within the function and functions it calls
+  - on error, leaks allocated: sipuri, username, query.
 
 
 
diff -r 915450ee91c7 -r ca7ca55e2488 extensions/app_sip/multimediaauth.c
--- a/extensions/app_sip/multimediaauth.c	Thu Feb 27 16:19:24 2020 +1100
+++ b/extensions/app_sip/multimediaauth.c	Thu Feb 27 16:27:48 2020 +1100
@@ -148,7 +148,7 @@
 				
 				if(not_found)
 				{
-					TRACE_DEBUG(FULL,"The user %s doesn't exist!",username);
+					TRACE_DEBUG(FULL,"The user %s doesn't exist!", avphdr->avp_value->os.data);
 					result="DIAMETER_ERROR_USER_UNKNOWN";
 					free(username);	
 					goto out;