Changeset 1240:0420ccc4671a in freeDiameter for libfdcore

Timestamp:

Oct 10, 2013, 11:30:55 PM (11 years ago)

Author:

Sebastien Decugis <sdecugis@freediameter.net>

Branch:

default

Phase:

public

Message:

Add a counter for the sent requests for which we did not wait for an answer. It might be relevant this value contributes to the load estimate of the remote peer, but it is not very reliable

Location:

libfdcore

Files:

• fdcore-internal.h (modified) (1 diff)
• p_sr.c (modified) (2 diffs)

libfdcore/fdcore-internal.h

@@ -130 +130 @@
         struct fd_list  exp; /* requests that have a timeout set, ordered by timeout */
         long            cnt; /* number of requests in the srs list */
+        long            cnt_lost; /* number of requests that have not been answered in time. 
+                                     It is decremented when an unexpected answer is received, so this may not be accurate. */
         pthread_mutex_t mtx; /* mutex to protect these lists */
         pthread_cond_t  cnd; /* cond var used by the thread that handles timeouts */

libfdcore/p_sr.c

@@ -164 +164 @@
                 fd_list_unlink(&first->chain);
                 srlist->cnt--;
+                srlist->cnt_lost++; /* We are not waiting for this answer anymore, but the remote peer may still be processing it. */
                 fd_list_unlink(&first->expire);
                 free(first);
@@ -280 +281 @@
                 srl_dump("Current list of SR: ", &srlist->srs);
                 *req = NULL;
+                if (srlist->cnt_lost > 0) {
+                        srlist->cnt_lost--; /* This is probably an answer for a request we already timedout. */
+                } /* else, probably a bug in the remote peer */
         } else {
                 /* Restore hop-by-hop id */