Changeset 1233:0b4abb03bcaf in freeDiameter

Timestamp:

Sep 4, 2013, 9:14:31 AM (11 years ago)

Author:

Sebastien Decugis <sdecugis@freediameter.net>

Branch:

default

Phase:

public

Message:

Fix double increment when realloc resulting in invalid SQL query

File:

• extensions/app_acct/acct_db.c (modified) (2 diffs)

extensions/app_acct/acct_db.c

@@ -175 +175 @@
         
         if (acct_config->tsfield) {
-                ADD_EXTEND("$%d, ", ++idx);
+                ++idx;
+                ADD_EXTEND("$%d, ", idx);
         }
         if (acct_config->srvnfield) {
@@ -185 +186 @@
         for (li = emptyrecords.all.next; li != &emptyrecords.all; li = li->next) {
                 struct acct_record_item * i = (struct acct_record_item *)(li->o);
-                ADD_EXTEND("$%d::%s", ++idx, diam2db_types_mapping[i->param->avptype]);
+                ++idx;
+                ADD_EXTEND("$%d::%s", idx, diam2db_types_mapping[i->param->avptype]);
                 
                 if (li->next != &emptyrecords.all) {