Changes in freeDiameter/p_expiry.c [16:013ce9851131:25:67ca08d5bc48] in freeDiameter

File:

• freeDiameter/p_expiry.c (modified) (6 diffs)

freeDiameter/p_expiry.c

@@ -47 +47 @@
 static void * gc_th_fct(void * arg)
 {
-        fd_log_threadname ( "Peers/garbage" );
-        TRACE_ENTRY( "" );
+        fd_log_threadname ( "Peers/garb. col." );
+        TRACE_ENTRY( "%p", arg );
         
         do {
                 struct fd_list * li, purge = FD_LIST_INITIALIZER(purge);
                 
-                pthread_testcancel();
-                sleep(GC_TIME);
+                sleep(GC_TIME); /* sleep is a cancellation point */
                 
                 /* Now check in the peers list if any peer can be deleted */
@@ -88 +87 @@
         TRACE_DEBUG(INFO, "An error occurred in peers module! GC thread is terminating...");
         ASSERT(0);
-        CHECK_FCT_DO(fd_event_send(fd_g_config->cnf_main_ev, FDEV_TERMINATE, NULL), );
+        CHECK_FCT_DO(fd_event_send(fd_g_config->cnf_main_ev, FDEV_TERMINATE, 0, NULL), );
         return NULL;
 }
@@ -96 +95 @@
 {
         fd_log_threadname ( "Peers/expire" );
-        TRACE_ENTRY( "" );
+        TRACE_ENTRY( "%p", arg );
         
         CHECK_POSIX_DO( pthread_mutex_lock(&exp_mtx),  goto error );
@@ -124 +123 @@
                         
                         CHECK_POSIX_DO2(  pthread_cond_timedwait( &exp_cnd, &exp_mtx, &first->p_exp_timer ),  
-                                        ETIMEDOUT, /* ETIMEDOUT is a normal error, continue */,
+                                        ETIMEDOUT, /* ETIMEDOUT is a normal return value, continue */,
                                         /* on other error, */ goto error );
         
@@ -133 +132 @@
                 /* Now, the first peer in the list is expired; signal it */
                 fd_list_unlink( &first->p_expiry );
-                CHECK_FCT_DO( fd_event_send(first->p_events, FDEVP_TERMINATE, NULL), goto error );
+                CHECK_FCT_DO( fd_event_send(first->p_events, FDEVP_TERMINATE, 0, NULL), goto error );
                 
         } while (1);
@@ -141 +140 @@
         TRACE_DEBUG(INFO, "An error occurred in peers module! Expiry thread is terminating...");
         ASSERT(0);
-        CHECK_FCT_DO(fd_event_send(fd_g_config->cnf_main_ev, FDEV_TERMINATE, NULL), );
+        CHECK_FCT_DO(fd_event_send(fd_g_config->cnf_main_ev, FDEV_TERMINATE, 0, NULL), );
         return NULL;
 }