Changeset 1318:2a5620128a9a in freeDiameter

Timestamp:

Jan 23, 2017, 11:26:25 PM (7 years ago)

Author:

Thomas Klausner <tk@giga.or.at>

Branch:

default

Phase:

public

Message:

Remove '*' from the couple enumerated values that had them.

This was inconsistent and caused trouble with extensions
that want to add enumerated values to existing enumerations.

Files:

• extensions/dict_dcca/dict_dcca.c (modified) (1 diff)
• extensions/dict_legacy_xml/dict_lxml_xml.c (modified) (1 diff)
• extensions/dict_nasreq/dict_nasreq.c (modified) (1 diff)
• extensions/dict_sip/dict_sip.c (modified) (1 diff)
• libfdcore/dict_base_proto.c (modified) (4 diffs)

extensions/dict_dcca/dict_dcca.c

@@ -80 +80 @@
     {
         struct dict_object *ResultCodeType;
-        CHECK_dict_search(DICT_TYPE, TYPE_BY_NAME, "Enumerated*(Result-Code)", &ResultCodeType);
+        CHECK_dict_search(DICT_TYPE, TYPE_BY_NAME, "Enumerated(Result-Code)", &ResultCodeType);
 
         {

extensions/dict_legacy_xml/dict_lxml_xml.c

@@ -1480 +1480 @@
                                 
 enumerated:
-                                snprintf(typename, sizeof(typename), "Enumerated*(%s)", ad.avp_name);
+                                snprintf(typename, sizeof(typename), "Enumerated(%s)", ad.avp_name);
                                 memset(&tdata, 0, sizeof(tdata));
                                 tdata.type_base = AVP_TYPE_INTEGER32;

extensions/dict_nasreq/dict_nasreq.c

@@ -468 +468 @@
                         */
                         struct dict_object      *type;
-                        struct dict_type_data    tdata = { AVP_TYPE_OCTETSTRING,        "Enumerated*(Originating-Line-Info)"    , NULL, NULL};
+                        struct dict_type_data    tdata = { AVP_TYPE_OCTETSTRING,        "Enumerated(Originating-Line-Info)"     , NULL, NULL};
                         struct dict_enumval_data tvals[] = {
                                 enumval_def_os( 2, "00", "Plain Old Telephone Service (POTS)"),

extensions/dict_sip/dict_sip.c

@@ -1439 +1439 @@
                 {
                         struct dict_object * resultcode_data_type;
-                        CHECK_dict_search(DICT_TYPE,TYPE_BY_NAME,"Enumerated*(Result-Code)",&resultcode_data_type);
+                        CHECK_dict_search(DICT_TYPE,TYPE_BY_NAME,"Enumerated(Result-Code)",&resultcode_data_type);
                 
 

libfdcore/dict_base_proto.c

@@ -810 +810 @@
                         
                         struct dict_object      *       type;
-                        struct dict_type_data           tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated*(Inband-Security-Id)"       , NULL, NULL, NULL };
+                        struct dict_type_data           tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated(Inband-Security-Id)"        , NULL, NULL, NULL };
                         struct dict_enumval_data        t_0 = { "NO_INBAND_SECURITY",           { .u32 = ACV_ISI_NO_INBAND_SECURITY }};
                         struct dict_enumval_data        t_1 = { "TLS",                  { .u32 = ACV_ISI_TLS }};
@@ -1105 +1105 @@
                          */
                         struct dict_object *    type;
-                        struct dict_type_data   tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated*(Result-Code)"      , NULL, NULL, NULL };
+                        struct dict_type_data   tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated(Result-Code)"       , NULL, NULL, NULL };
                         struct dict_avp_data    data = { 
                                         268,                                    /* Code */
@@ -1631 +1631 @@
                          */
                         struct dict_object *    type;
-                        struct dict_type_data   tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated*(Experimental-Result-Code)" , NULL, NULL, NULL };
+                        struct dict_type_data   tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated(Experimental-Result-Code)"  , NULL, NULL, NULL };
                         struct dict_avp_data    data = { 
                                         298,                                    /* Code */
@@ -2102 +2102 @@
                         
                         struct dict_object      *       type;
-                        struct dict_type_data           tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated*(Session-Binding)"  , NULL, NULL, NULL };
+                        struct dict_type_data           tdata = { AVP_TYPE_UNSIGNED32,  "Enumerated(Session-Binding)"   , NULL, NULL, NULL };
                         struct dict_enumval_data        t_1 = { "RE_AUTH",              { .u32 = 1 }};
                         struct dict_enumval_data        t_2 = { "STR",                  { .u32 = 2 }};