Changeset 720:2c7c423eaba9 in freeDiameter

Timestamp:

Feb 21, 2011, 6:30:20 PM (13 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Have AVP values 0-terminated for safety (one should not rely on this and use the size)

File:

• libfdproto/messages.c (modified) (1 diff)

libfdproto/messages.c

@@ -1773 +1773 @@
                         avp->avp_storage.os.len = avp->avp_public.avp_len - GETAVPHDRSZ( avp->avp_public.avp_flags );
                         if (avp->avp_storage.os.len) {
-                                CHECK_MALLOC(  avp->avp_storage.os.data = malloc(avp->avp_storage.os.len)  );
+                                CHECK_MALLOC(  avp->avp_storage.os.data = os0dup(avp->avp_source, avp->avp_storage.os.len)  );
                                 avp->avp_mustfreeos = 1;
-                                memcpy(avp->avp_storage.os.data, avp->avp_source, avp->avp_storage.os.len);
                         } else {
                                 avp->avp_storage.os.data = NULL;