Changeset 1559:2dbc816d48f4 in freeDiameter for libfdcore

Timestamp:

Oct 27, 2020, 6:50:04 PM (3 years ago)

Author:

Thomas Klausner <wiz@gatalith.at>

Branch:

default

Phase:

public

Message:

Fail when a peer with empty Origin-Realm tries to connect.

Empty Origin-Realms cause problems in the routing code later.

Reduce warnings when reporting an empty Failed-AVP;
both avp_source and avp_rawdata are NULL in this case.

File:

• libfdcore/p_ce.c (modified) (1 diff)

libfdcore/p_ce.c

@@ -337 +337 @@
                                 }
                                 
+                                /* Origin-Realm is empty */
+                                if (hdr->avp_value->os.len == 0) {
+                                        error->pei_errcode = "DIAMETER_INVALID_AVP_VALUE";
+                                        error->pei_message = "Your Origin-Realm is empty.";
+                                        error->pei_avp = avp;
+                                        return EINVAL;
+                                }
+
                                 /* Save the value */
                                 CHECK_MALLOC(  peer->p_hdr.info.runtime.pir_realm = os0dup( hdr->avp_value->os.data, hdr->avp_value->os.len )  );