Changeset 385:69057a6d68ec in freeDiameter

Timestamp:

Jul 5, 2010, 6:45:07 PM (14 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Fix a possible race condition

Location:

extensions/app_radgw

Files:

• rgw_worker.c (modified) (2 diffs)
• rgwx_auth.c (modified) (1 diff)

extensions/app_radgw/rgw_worker.c

@@ -292 +292 @@
         }
         
-        /* Now try and send the RADIUS answer */
-        if (rad_ans) {
-                CHECK_FCT_DO( rgw_client_finish_send(&rad_ans, pa->rad, pa->cli), goto out);    
-        }
-
-out:
+        
         if (!keepsession) {
                 /* Destroy remaining session data (stateless gateway) */
@@ -303 +298 @@
         }
         
+        /* Now try and send the RADIUS answer */
+        if (rad_ans) {
+                CHECK_FCT_DO( rgw_client_finish_send(&rad_ans, pa->rad, pa->cli), );    
+        }
+
+out:
         /* Clear the Diameter message */
         if (*ans) {

extensions/app_radgw/rgwx_auth.c

@@ -1052 +1052 @@
 
         /* Store the request identifier in the session (if provided) */
-        if (session) {
+        if (*session) {
                 unsigned char * req_auth;
                 CHECK_MALLOC(req_auth = malloc(16));