Changeset 1528:3908b839dcf2 in freeDiameter for extensions

Timestamp:

Apr 18, 2020, 1:26:28 PM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

Message:

Rename Assistance-info and MIC-Check-Indicator

3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802)
incorrect name and should be "Assistance-Info" per clause 6.3.3.
Fix: Assistance-info (3802) renamed to Assistance-Info (3802).

3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has
incorrect name and should be "MIC-Check-Indicator" per clause 6.3.80.
Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865).

Location:

extensions/dict_dcca_3gpp

Files:

• add_avps.c (modified) (2 diffs)
• dict_dcca_3gpp.csv (modified) (2 diffs)

extensions/dict_dcca_3gpp/add_avps.c

@@ -13760 +13760 @@
         };
 
-        /* Assistance-info, Grouped, code 3802, section 6.3.3               */
+        /* Note: 3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802) has */
+        /* incorrect name and should be "Assistance-Info" per clause 6.3.3. */
+        /*                                                                  */
+        /* Fix: Assistance-info (3802) renamed to Assistance-Info (3802).   */
+        /* Assistance-Info, Grouped, code 3802, section 6.3.3               */
         {
                 struct dict_avp_data data = {
                         3802,   /* Code */
                         10415,  /* Vendor */
-                        "Assistance-info",      /* Name */
+                        "Assistance-Info",      /* Name */
                         AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,    /* Fixed flags */
                         AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,    /* Fixed flag values */
@@ -14585 +14589 @@
         };
 
-        /* MIC-Check-indicator, Unsigned32, code 3865, section 6.3.80       */
+        /* Note: 3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has */
+        /* incorrect name and should be "MIC-Check-Indicator" per clause 6.3.80. */
+        /*                                                                  */
+        /* Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865). */
+        /* MIC-Check-Indicator, Unsigned32, code 3865, section 6.3.80       */
         {
                 struct dict_avp_data data = {
                         3865,   /* Code */
                         10415,  /* Vendor */
-                        "MIC-Check-indicator",  /* Name */
+                        "MIC-Check-Indicator",  /* Name */
                         AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,    /* Fixed flags */
                         AVP_FLAG_VENDOR,        /* Fixed flag values */

extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv

@@ -1649 +1649 @@
 #,,,,,,,
 App-Layer-User-Id,3801,6.3.2,UTF8String,"M, V",,,
-Assistance-info,3802,6.3.3,Grouped,"M, V",,,
+# Note: 3GPP TS 29.345 Table 6.3.1-1 row Assistance-info (3802) has,,,,,,,
+"# incorrect name and should be ""Assistance-Info"" per clause 6.3.3.",,,,,,,
+# ,,,,,,,
+# Fix: Assistance-info (3802) renamed to Assistance-Info (3802).,,,,,,,
+Assistance-Info,3802,6.3.3,Grouped,"M, V",,,
 Assistance-Info-Validity-Timer,3803,6.3.4,Unsigned32,"M, V",,,
 Discovery-Type,3804,6.3.5,Unsigned32,"M, V",,,
@@ -1715 +1719 @@
 DUIK,3863,6.3.78,OctetString,V,,,M
 DUCK,3864,6.3.79,OctetString,V,,,M
-MIC-Check-indicator,3865,6.3.80,Unsigned32,V,,,M
+# Note: 3GPP TS 29.345 Table 6.3.1-1 row MIC-Check-indicator (3865) has,,,,,,,
+"# incorrect name and should be ""MIC-Check-Indicator"" per clause 6.3.80.",,,,,,,
+# ,,,,,,,
+# Fix: MIC-Check-indicator (3865) renamed to MIC-Check-Indicator (3865).,,,,,,,
+MIC-Check-Indicator,3865,6.3.80,Unsigned32,V,,,M
 Encrypted-Bitmask,3866,6.3.81,OctetString,V,,,M
 ProSe-App-Code-Suffix-Range,3867,6.3.82,OctetString,V,,,M