Changeset 1405:3cbe458fbfa9 in freeDiameter

Timestamp:

Feb 18, 2020, 2:23:53 PM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

Message:

Fix compiler warnings

Files:

• extensions/acl_wl/aw_tree.c (modified) (1 diff)
• extensions/app_diameap/diameap_server.c (modified) (1 diff)
• extensions/app_radgw/rgw_clients.c (modified) (1 diff)
• extensions/app_sip/multimediaauth.c (modified) (1 diff)
• extensions/dbg_monitor/dbg_monitor.c (modified) (1 diff)
• libfdcore/hooks.c (modified) (1 diff)
• libfdcore/p_ce.c (modified) (1 diff)
• libfdcore/sctp3436.c (modified) (1 diff)
• libfdproto/dictionary_functions.c (modified) (1 diff)
• libfdproto/fifo.c (modified) (3 diffs)
• libfdproto/messages.c (modified) (1 diff)

extensions/acl_wl/aw_tree.c

@@ -340 +340 @@
         struct split_name sn;
         int lbl, found;
-        struct tree_item * ti;
+        struct tree_item * ti = NULL;
         struct fd_list * senti, *li;
         

extensions/app_diameap/diameap_server.c

@@ -3065 +3065 @@
         struct diameap_state_machine * diameap_sm = NULL;
         struct diameap_eap_interface eap_i;
-        struct msg *req, *ans;
+        struct msg *req, *ans = NULL;
         boolean non_fatal_error = FALSE;
 

extensions/app_radgw/rgw_clients.c

@@ -549 +549 @@
         int valid_nas_info = 0;
         struct radius_attr_hdr *nas_ip = NULL, *nas_ip6 = NULL, *nas_id = NULL;
-        size_t nas_id_len;
+        size_t nas_id_len = 0;
         char * oh_str = NULL; size_t oh_strlen = 0; int oh_free = 0;
         char * or_str = NULL; size_t or_strlen = 0;

extensions/app_sip/multimediaauth.c

@@ -51 +51 @@
         int found_cnonce=0;
         struct avp * tempavp=NULL,*sipAuthentication=NULL,*sipAuthenticate=NULL;
-        char * result;
+        char * result = NULL;
         char password[51];
         int idx=0, number_of_auth_items=0,i=0, ret=0;

extensions/dbg_monitor/dbg_monitor.c

@@ -76 +76 @@
 static void * mn_thr(void * arg)
 {
+#ifdef DEBUG
         int i = 0;
+#endif
         fd_log_threadname("Monitor thread");
         char * buf = NULL;

libfdcore/hooks.c

@@ -333 +333 @@
                 switch (type) {
                         case HOOK_DATA_RECEIVED: {
+#ifdef DEBUG
                                 struct fd_cnx_rcvdata *rcv_data = other;
+#endif
                                 LOG_A("RCV: %zd bytes", rcv_data->length);
                                 break;

libfdcore/p_ce.c

@@ -705 +705 @@
 {
         uint32_t rc = 0;
-        int st;
+        int st = STATE_NEW;
         struct fd_pei pei;
         

libfdcore/sctp3436.c

@@ -138 +138 @@
 {
         struct sctp3436_ctx * ctx = arg;
-        struct cnxctx    *cnx;
+        struct cnxctx    *cnx = NULL;
 
         TRACE_ENTRY("%p", arg);

libfdproto/dictionary_functions.c

@@ -288 +288 @@
 int fd_dictfct_Time_encode(void * data, union avp_value * avp_value)
 {
-        char * buf;
+        char * buf = NULL;
         size_t len;
         

libfdproto/fifo.c

@@ -171 +171 @@
 {
         struct fifo * q;
+#ifdef DEBUG
         int loops = 0;
+#endif
 
         TRACE_ENTRY( "%p", queue );
@@ -226 +228 @@
 int fd_fifo_move ( struct fifo * old, struct fifo * new, struct fifo ** loc_update )
 {
+#ifdef DEBUG
         int loops = 0;
+#endif
 
         TRACE_ENTRY("%p %p %p", old, new, loc_update);
@@ -417 +421 @@
                         queue->thrs_push-- ;
 
+#ifndef DEBUG
+                        (void)ret;
+#endif
                         ASSERT( ret == 0 );
                 }

libfdproto/messages.c

@@ -2285 +2285 @@
         if (msg->msg_model != NULL) {
                 /* Check if this model is still valid for the message data */
+#ifdef DEBUG
                 enum dict_object_type    dicttype;
+#endif
                 struct dict_cmd_data     data;
                 ASSERT(((fd_dict_gettype(msg->msg_model, &dicttype) == 0) && (dicttype == DICT_COMMAND)));