Changeset 1547:44bb63ba9c2c in freeDiameter for extensions

Timestamp:

Jun 16, 2020, 3:33:35 AM (4 years ago)

Author:

Thomas Klausner <tk@giga.or.at>

Branch:

default

Phase:

public

Message:

rt_rewrite: allocate object later to reduce cleanups

File:

• extensions/rt_rewrite/rt_rewrite.c (modified) (1 diff)

extensions/rt_rewrite/rt_rewrite.c

@@ -398 +398 @@
         }
 
+        if ((ret = fd_msg_parse_dict(*msg, fd_g_config->cnf_dict, NULL)) != 0) {
+                fd_log_notice("%s: error parsing message", MODULE_NAME);
+                pthread_rwlock_unlock(&rt_rewrite_lock);
+                return ret;
+        }
+        if ((ret=fd_msg_browse(*msg, MSG_BRW_FIRST_CHILD, &avp, NULL)) != 0) {
+                fd_log_notice("internal error: message has no child");
+                pthread_rwlock_unlock(&rt_rewrite_lock);
+                return ret;
+        }
         if ((store=store_new()) == NULL) {
                 fd_log_error("%s: malloc failure");
                 pthread_rwlock_unlock(&rt_rewrite_lock);
                 return ENOMEM;
-        }
-        if ((ret = fd_msg_parse_dict(*msg, fd_g_config->cnf_dict, NULL)) != 0) {
-                fd_log_notice("%s: error parsing message", MODULE_NAME);
-                free(store);
-                pthread_rwlock_unlock(&rt_rewrite_lock);
-                return ret;
-        }
-        if ((ret=fd_msg_browse(*msg, MSG_BRW_FIRST_CHILD, &avp, NULL)) != 0) {
-                fd_log_notice("internal error: message has no child");
-                free(store);
-                pthread_rwlock_unlock(&rt_rewrite_lock);
-                return ret;
         }
         if (replace_avps(*msg, avp, avp_match_start->children, store) != 0) {