Changeset 564:603f70bf1453 in freeDiameter

Timestamp:

Sep 17, 2010, 5:23:46 PM (14 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Cleanly destroy Diameter message when an Accounting Response is not generated in gateway

File:

• extensions/app_radgw/rgwx_acct.c (modified) (4 diffs)

extensions/app_radgw/rgwx_acct.c

@@ -1225 +1225 @@
 static int acct_diam_ans( struct rgwp_config * cs, struct session * session, struct msg ** diam_ans, struct radius_msg ** rad_fw, struct rgw_client * cli, int * stateful )
 {
-        struct sess_state * st = NULL;
+        struct sess_state * st = NULL, stloc;
         struct avp *avp, *next;
         struct avp_hdr *ahdr, *sid, *oh, *or;
@@ -1240 +1240 @@
                 return EINVAL;
         }
+        
+        /* Free the state */
+        memcpy(&stloc, st, sizeof(struct sess_state));
+        free(st);
+        st = &stloc;
         
         /* Search these AVPs first */
@@ -1283 +1288 @@
                                 /* Dump its content ? */
                         }
+                        
+                        /* Now, destroy the Diameter message, since we know it is not converted to RADIUS */
+                        CHECK_FCT( fd_msg_free(*diam_ans) );
+                        *diam_ans = NULL;
+
                         return -1;
         }
@@ -1426 +1436 @@
         */
 
-        free(st);
-
         return 0;
 }