Changeset 539:6994e9a3c528 in freeDiameter

Timestamp:

Sep 11, 2010, 8:52:36 AM (14 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

The previous commit provoked an Accounting-Response with empty authenticator... Should be fixed now.

Location:

extensions/app_radgw

Files:

• radius.c (modified) (1 diff)
• rgw_clients.c (modified) (1 diff)

extensions/app_radgw/radius.c

@@ -349 +349 @@
         size_t len[4];
 
-        os_memset(auth, 0, MD5_MAC_LEN);
-        attr = radius_msg_add_attr(msg, RADIUS_ATTR_MESSAGE_AUTHENTICATOR,
-                                   auth, MD5_MAC_LEN);
-        if (attr == NULL) {
-                printf("WARNING: Could not add Message-Authenticator\n");
-                return -1;
+        if (msg->hdr->code != RADIUS_CODE_ACCOUNTING_RESPONSE) {
+            os_memset(auth, 0, MD5_MAC_LEN);
+            attr = radius_msg_add_attr(msg, RADIUS_ATTR_MESSAGE_AUTHENTICATOR,
+                                       auth, MD5_MAC_LEN);
+            if (attr == NULL) {
+                    printf("WARNING: Could not add Message-Authenticator\n");
+                    return -1;
+            }
         }
         msg->hdr->length = htons(msg->buf_used);

extensions/app_radgw/rgw_clients.c

@@ -841 +841 @@
         }
         
-        if ((*msg)->hdr->code != RADIUS_CODE_ACCOUNTING_RESPONSE) {
-            if (radius_msg_finish_srv(*msg, cli->key.data, cli->key.len, req->radius.hdr->authenticator)) {
-                    TRACE_DEBUG(INFO, "An error occurred while preparing the RADIUS answer");
-                    radius_msg_free(*msg);
-                    free(*msg);
-                    *msg = NULL;
-                    return EINVAL;
-            }
+        if (radius_msg_finish_srv(*msg, cli->key.data, cli->key.len, req->radius.hdr->authenticator)) {
+                TRACE_DEBUG(INFO, "An error occurred while preparing the RADIUS answer");
+                radius_msg_free(*msg);
+                free(*msg);
+                *msg = NULL;
+                return EINVAL;
         }