Changeset 1438:7c60cb0ac8c8 in freeDiameter

Timestamp:

Feb 21, 2020, 12:30:16 PM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

committer:

Luke Mewburn <luke@mewburn.net> 1582584400 -39600

Message:

testmesg: improve comments and msg cleanup

File:

• tests/testmesg.c (modified) (5 diffs)

tests/testmesg.c

@@ -165 +165 @@
                 /* Create the instance, using the templates */
                 CHECK( 0, fd_msg_new ( acr_model, 0, &acr ) );
+
+/* TODO: Do we need this recreated? acr is not used again . */
         }
         
@@ -701 +703 @@
                         struct avp_hdr     * avpdata = NULL;
                         
-                        /* Now find the ACR dictionary object */
+                        /* Now find the Test f32 AVP dictionary object */
                         CHECK( 0, fd_dict_search ( fd_g_config->cnf_dict, DICT_AVP, AVP_BY_NAME, "AVP Test - no vendor - f32", &avp_model, ENOENT ) );
                         
@@ -1116 +1118 @@
                                 
                                 TODO("Check the Failed-AVP is as expected");
+
+                                CHECK( 0, fd_msg_free( msg ) );
                         }
                         
@@ -1510 +1514 @@
 
                         /* Add a session id */
-                        CHECK( 0, fd_msg_new_session( msg, (os0_t)"tm2", strlen("tm2") ) );
+                        CHECK( 0, fd_msg_new_session( msg, (os0_t)"testmsg", strlen("testmsg") ) );
 
                         /* Find the DICT_TYPE Enumerated(Result-Code) */
@@ -1554 +1558 @@
 
                         /* Add a session id */
-                        CHECK( 0, fd_msg_new_session( msg, (os0_t)"tm2", strlen("tm2") ) );
+                        CHECK( 0, fd_msg_new_session( msg, (os0_t)"testmsg", strlen("testmsg") ) );
 
                         /* Find the DICT_TYPE Enumerated(73565/Experimental-Result-Code) */