Changeset 1523:7f7a7cc2ce1f in freeDiameter

Timestamp:

Apr 18, 2020, 9:20:07 AM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

Message:

Fix types of 3GPP Max-PLR-DL, Max-PLR-UL

3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852)
incorrectly lists type as Unsigned32 instead of Float32.
3GPP TS 29.212 clause 5.3.138 uses Float32.
Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.

3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853)
incorrectly lists type as Unsigned32 instead of Float32.
3GPP TS 29.212 clause 5.3.139 uses Float32.
Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.

Location:

extensions/dict_dcca_3gpp

Files:

• add_avps.c (modified) (3 diffs)
• dict_dcca_3gpp.csv (modified) (1 diff)

extensions/dict_dcca_3gpp/add_avps.c

@@ -4004 +4004 @@
         };
 
-        /* Max-PLR-DL, Float32, code 2852, section 5.3.138                  */
+        /* Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852)         */
+        /* incorrectly lists type as Unsigned32 instead of Float32.         */
+        /* 3GPP TS 29.212 clause 5.3.138 uses Float32.                      */
+        /*                                                                  */
+        /* Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.  */
+        /* Max-PLR-DL, Unsigned32, code 2852, section 5.3.138               */
         {
                 struct dict_avp_data data = {
@@ -4012 +4017 @@
                         AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,    /* Fixed flags */
                         AVP_FLAG_VENDOR,        /* Fixed flag values */
-                        AVP_TYPE_FLOAT32        /* base type of data */
-                };
-                CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
-        };
-
-        /* Max-PLR-UL, Float32, code 2853, section 5.3.139                  */
+                        AVP_TYPE_UNSIGNED32     /* base type of data */
+                };
+                CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
+        };
+
+        /* Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853)         */
+        /* incorrectly lists type as Unsigned32 instead of Float32.         */
+        /* 3GPP TS 29.212 clause 5.3.139 uses Float32.                      */
+        /*                                                                  */
+        /* Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.  */
+        /* Max-PLR-UL, Unsigned32, code 2853, section 5.3.139               */
         {
                 struct dict_avp_data data = {
@@ -4025 +4035 @@
                         AVP_FLAG_VENDOR |AVP_FLAG_MANDATORY,    /* Fixed flags */
                         AVP_FLAG_VENDOR,        /* Fixed flag values */
-                        AVP_TYPE_FLOAT32        /* base type of data */
+                        AVP_TYPE_UNSIGNED32     /* base type of data */
                 };
                 CHECK_dict_new(DICT_AVP, &data, NULL, NULL);

extensions/dict_dcca_3gpp/dict_dcca_3gpp.csv

@@ -538 +538 @@
 IP-CAN-Session-Charging-Scope,2827,5.3.114,Enumerated,V,P,,M
 IP-CAN-Type,1027,5.3.27,Enumerated,"M,V",P,,
-Max-PLR-DL,2852,5.3.138,Float32,V,P,,M
-Max-PLR-UL,2853,5.3.139,Float32,V,P,,M
+# Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-DL (2852),,,,,,,
+# incorrectly lists type as Unsigned32 instead of Float32.,,,,,,,
+# 3GPP TS 29.212 clause 5.3.138 uses Float32.,,,,,,,
+# ,,,,,,,
+# Fix: Max-PLR-DL (2852) type changed from Float32 to Unsigned32.,,,,,,,
+Max-PLR-DL,2852,5.3.138,Unsigned32,V,P,,M
+# Note: 3GPP TS 29.212 table 5.3.0.1 row Max-PLR-UL (2853),,,,,,,
+# incorrectly lists type as Unsigned32 instead of Float32.,,,,,,,
+# 3GPP TS 29.212 clause 5.3.139 uses Float32.,,,,,,,
+# ,,,,,,,
+# Fix: Max-PLR-UL (2853) type changed from Float32 to Unsigned32.,,,,,,,
+Max-PLR-UL,2853,5.3.139,Unsigned32,V,P,,M
 Metering-Method,1007,5.3.8,Enumerated,"M,V",P,,
 Monitoring-Flags,2828,5.3.115,Unsigned32,V,,,M