Changeset 1442:915450ee91c7 in freeDiameter for libfdproto

Timestamp:

Feb 27, 2020, 2:19:24 PM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

Message:

fix gcc 9.1.1 compile warnings

Use snprintf instead of strncpy to ensure NUL termination.

Simplify attribute copying to calloc/memcpy instead
of malloc/memset/strncpy/assignment.

Appeases gcc 9.1.1 warnings about strncpy bounds.

File:

• libfdproto/messages.c (modified) (1 diff)

libfdproto/messages.c

@@ -2235 +2235 @@
                                                 error_info->pei_errcode = "DIAMETER_INVALID_AVP_VALUE";
                                                 error_info->pei_avp = avp;
-                                                strncpy(error_message, err, sizeof(error_message));
+                                                snprintf(error_message, sizeof(error_message), "%s", err);
                                                 error_info->pei_message = error_message;
                                 } else {