Changeset 293:ec67c5096eeb in freeDiameter

Timestamp:

May 10, 2010, 2:43:06 PM (14 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Fix small issue with access to freed memory

File:

• libfreeDiameter/sessions.c (modified) (3 diffs)

libfreeDiameter/sessions.c

@@ -591 +591 @@
 {
         struct session * sess;
+        uint32_t hash;
         
         TRACE_ENTRY("%p", session);
@@ -596 +597 @@
         
         sess = *session;
+        hash = sess->hash;
         *session = NULL;
         
-        CHECK_FCT( pthread_mutex_lock( H_LOCK(sess->hash) ) );
+        CHECK_POSIX( pthread_mutex_lock( H_LOCK(sess->hash) ) );
         pthread_cleanup_push( fd_cleanup_mutex, H_LOCK(sess->hash) );
-        CHECK_FCT( pthread_mutex_lock( &exp_lock ) );
+        CHECK_POSIX( pthread_mutex_lock( &exp_lock ) );
         if (FD_IS_LIST_EMPTY(&sess->states)) {
                 fd_list_unlink( &sess->chain_h );
@@ -608 +610 @@
                 free(sess);
         }
-        CHECK_FCT( pthread_mutex_unlock( &exp_lock ) );
+        CHECK_POSIX( pthread_mutex_unlock( &exp_lock ) );
         pthread_cleanup_pop(0);
-        CHECK_FCT( pthread_mutex_unlock( H_LOCK(sess->hash) ) );
+        CHECK_POSIX( pthread_mutex_unlock( H_LOCK(hash) ) );
         
         return 0;