diff extensions/dict_dcca_3gpp/dict_dcca_3gpp.c @ 1485:a0ca9ac32a3a

dict_dcca_3gpp: more comment improvements Don't bother with comments for AVPs in tables that are referenced from other sources. Add comment explicitly describing AVP renames.
author Luke Mewburn <luke@mewburn.net>
date Fri, 27 Mar 2020 10:05:54 +1100
parents 3bf80555f00a
children eeb5706333c3
line wrap: on
line diff
--- a/extensions/dict_dcca_3gpp/dict_dcca_3gpp.c	Fri Mar 27 09:55:33 2020 +1100
+++ b/extensions/dict_dcca_3gpp/dict_dcca_3gpp.c	Fri Mar 27 10:05:54 2020 +1100
@@ -1407,6 +1407,8 @@
 
 	/*==================================================================*/
 	/* 3GPP TS 29.140 Table 6.3.1: Diameter MM10 Application AVPs       */
+	/*                                                                  */
+	/* Note: AVPs referenced from other sources are not added here.     */
 	/*==================================================================*/
 
 	/* Served-User-Identity, Grouped, code 1100, section 6.3.1          */
@@ -1422,8 +1424,6 @@
 		CHECK_dict_new(DICT_AVP, &data, NULL, NULL);
 	};
 
-	/* Note: Uses 3GPP TS 29.329 MSISDN (701).                          */
-
 	/* VASP-ID, UTF8String, code 1101, section 6.3.3                    */
 	{
 		struct dict_avp_data data = {
@@ -1466,8 +1466,6 @@
 		CHECK_dict_new(DICT_AVP, &data, type, NULL);
 	};
 
-	/* Note: Uses 3GPP TS 29.061 3GPP-IMSI (1).                         */
-
 	/* Sender-Address, UTF8String, code 1104, section 6.3.7             */
 	{
 		struct dict_avp_data data = {
@@ -1508,6 +1506,7 @@
 	};
 
 	/* Note: Name conflict with 3GPP TS 32.329 Sequence-Number (716).   */
+	/* Sequence-Number (1107) renamed to Sequence-Number-29.140 (1107). */
 	/* Sequence-Number-29.140, Unsigned32, code 1107, section 6.3.10    */
 	{
 		struct dict_avp_data data = {
@@ -1522,6 +1521,7 @@
 	};
 
 	/* Note: Name conflict with 3GPP TS 32.299 Recipient-Address (1201). */
+	/* Recipient-Address (1108) renamed to Recipient-Address-29.140 (1108). */
 	/* Recipient-Address-29.140, UTF8String, code 1108, section 6.3.11  */
 	{
 		struct dict_avp_data data = {
"Welcome to our mercurial repository"