Changeset 776:03b8d4544842 in freeDiameter for extensions/dict_mip6a

Timestamp:

Nov 23, 2011, 9:34:16 AM (12 years ago)

Author:

Romain Kuntz <rkuntz@us.toyota-itc.com>

Branch:

default

Phase:

public

Message:

Fixed the mip6a dictionnary. The MIP-Agent-Info AVP does not exist and should be MIP6-Agent-Info (I reported an errata to the RFC5778). The MIP6-Answer command must set the CMD_FLAG_REQUEST flag mask (mandated by libfdproto/dictionary.c in fd_dict_new(), which checks if the flag is set for DICT_COMMAND)

File:

• extensions/dict_mip6a/dict_mip6a.c (modified) (7 diffs)

extensions/dict_mip6a/dict_mip6a.c

@@ -81 +81 @@
         MIP6-Feature-Vector                     ----------------------------------
         MIP-Mobile-Node-Address                 ----------------------------------
-        MIP-Agent-Info                          ----------------------------------
+        MIP6-Agent-Info                         ----------------------------------
         Chargeable-User-Identity                ----------------------------------
         Service-Selection                       ----------------------------------
@@ -962 +962 @@
                                         "MIP6-Request",                         /* Name */
                                         CMD_FLAG_REQUEST | CMD_FLAG_PROXIABLE | CMD_FLAG_ERROR,         /* Fixed flags */
-                                        CMD_FLAG_PROXIABLE                                              /* Fixed flag values */
+                                        CMD_FLAG_REQUEST | CMD_FLAG_PROXIABLE                                           /* Fixed flag values */
                                         };
                         struct local_rules_definition rules[] =
@@ -1000 +1000 @@
                                                 };
 
-                        CHECK_dict_new( DICT_COMMAND, &data , mip6a, &cmd);
+                        CHECK_dict_new( DICT_COMMAND, &data, mip6a, &cmd);
                         PARSE_loc_rules( rules, cmd );
                 }
@@ -1035 +1035 @@
                                           [ Re-Auth-Request-Type ]
                                           [ MIP6-Feature-Vector ]
-                                          [ MIP-Agent-Info ]
+                                          [ MIP6-Agent-Info ]
                                         *2[ MIP-Mobile-Node-Address ]
                                           [ MIP-MN-HA-MSA ]
@@ -1054 +1054 @@
                                         325,                                    /* Code */
                                         "MIP6-Answer",                          /* Name */
-                                        CMD_FLAG_PROXIABLE | CMD_FLAG_ERROR,    /* Fixed flags */
+                                        CMD_FLAG_REQUEST | CMD_FLAG_PROXIABLE | CMD_FLAG_ERROR,         /* Fixed flags */
                                         CMD_FLAG_PROXIABLE                      /* Fixed flag values */
                                         };
@@ -1071 +1071 @@
                                                         ,{  "Re-Auth-Request-Type",             RULE_OPTIONAL,   -1, 1 }
                                                         ,{  "MIP6-Feature-Vector",              RULE_OPTIONAL,   -1, 1 }
-                                                        ,{  "MIP-Agent-Info",                   RULE_OPTIONAL,   -1, 1 }
+                                                        ,{  "MIP6-Agent-Info",                  RULE_OPTIONAL,   -1, 1 }
                                                         ,{  "MIP-Mobile-Node-Address",          RULE_OPTIONAL,   -1, 2 }
                                                         ,{  "MIP-MN-HA-MSA",                    RULE_OPTIONAL,   -1, 1 }
@@ -1085 +1085 @@
                                                 };
 
-                        CHECK_dict_new( DICT_COMMAND, &data , mip6a, &cmd);
+                        CHECK_dict_new( DICT_COMMAND, &data, mip6a, &cmd);
                         PARSE_loc_rules( rules, cmd );
                 }