Changeset 749:2557127f3c8b in freeDiameter for libfdcore/peers.c

Timestamp:

Aug 8, 2011, 4:03:49 AM (13 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

fix bug reported by Vjacheslav Chekushin on the mailing-list (thanks\!)

File:

• libfdcore/peers.c (modified) (4 diffs)

libfdcore/peers.c

@@ -456 +456 @@
         msg = *cer; 
         
-        /* If needed, resolve the dictioanry model for Origin-Host */
+        /* If needed, resolve the dictionary model for Origin-Host */
         CHECK_POSIX( pthread_mutex_lock(&cache_avp_lock) );
         if (!avp_oh_model) {
@@ -471 +471 @@
         CHECK_FCT( fd_msg_avp_hdr ( avp_oh, &avp_hdr ) );
         
-        /* First, check if the Origin-Host value  */
+        /* First, check if the Origin-Host value is valid */
         if (!fd_os_is_valid_DiameterIdentity(avp_hdr->avp_value->os.data, avp_hdr->avp_value->os.len)) {
                 TRACE_DEBUG(INFO, "Received new CER with invalid Origin-Host");
@@ -489 +489 @@
         for (li = fd_g_peers.next; li != &fd_g_peers; li = li->next) {
                 int cmp, cont;
-                peer = (struct fd_peer *)li->o;
+                peer = (struct fd_peer *)li;
                 cmp = fd_os_almostcasesrch( avp_hdr->avp_value->os.data, avp_hdr->avp_value->os.len, peer->p_hdr.info.pi_diamid, peer->p_hdr.info.pi_diamidlen, &cont );
-                if (cmp < 0) {
+                if (cmp > 0) {
                         li_inf = li;
-                        continue;
                 }
                 if (cmp == 0) {
@@ -520 +519 @@
                 peer->p_hdr.info.config.pic_lft         = 3600; /* 1 hour without any message 
                 -- RFC3539 states that this must not be inferior to BRINGDOWN_INTERVAL = 5 minutes */
+                CHECK_FCT_DO( ret = fd_p_expi_update( peer ), goto out );
+
                 
                 /* Insert the new peer in the list (the PSM will take care of setting the expiry after validation) */