Changeset 1119:79dd22145f52 in freeDiameter for extensions/app_radgw

Timestamp:

May 14, 2013, 12:04:20 PM (11 years ago)

Author:

Sebastien Decugis <sdecugis@freediameter.net>

Branch:

default

Phase:

public

Message:

Fix a number of compilation warnings

Location:

extensions/app_radgw

Files:

• rgw_clients.c (modified) (1 diff)
• rgwx_acct.c (modified) (1 diff)
• rgwx_auth.c (modified) (1 diff)
• rgwx_debug.c (modified) (2 diffs)
• rgwx_echodrop.c (modified) (1 diff)
• rgwx_sip.c (modified) (1 diff)

extensions/app_radgw/rgw_clients.c

@@ -976 +976 @@
                 char sa_buf[sSA_DUMP_STRLEN];
                 client = (struct rgw_client *)ref;
-                /* TODO: use a fct param instead of hardcoded FD_LOG_DEBUG */
-                TODO("Replace with appropriate code");
-/*              TRACE_sSA(FD_LOG_DEBUG, NONE,    "  - ", client->sa, NI_NUMERICHOST | NI_NUMERICSERV, (client->type == RGW_CLI_NAS) ? "" : " [PROXY]" ); */
+                fd_sa_sdump_numeric(sa_buf, client->sa);
+                LOG_D("  - %s%s", sa_buf, (client->type == RGW_CLI_NAS) ? "" : " [PROXY]" );
         }
 }

extensions/app_radgw/rgwx_acct.c

@@ -1220 +1220 @@
 out:
         if (answer && *answer) {
-                TRACE_DEBUG(INFO, "Received the following problematic STA message, discarding anyway...");
-                fd_msg_dump_walk( INFO, *answer );
+                char * buf = NULL; size_t buflen;
+                CHECK_MALLOC_DO( fd_msg_dump_treeview(&buf, &buflen, NULL, *answer, NULL, 0, 1), );
+                TRACE_DEBUG(INFO, "Received the following problematic STA message, discarding anyway: %s", buf ?: "<error>");
+                free(buf);
+                
                 fd_msg_free(*answer);
                 *answer = NULL;

extensions/app_radgw/rgwx_auth.c

@@ -126 +126 @@
 
 struct sess_state {
-        char req_auth[16];
+        uint8_t req_auth[16];
 };
 

extensions/app_radgw/rgwx_debug.c

@@ -95 +95 @@
                 fd_log_debug(" Diameter message: NULL pointer");
         } else {
-                fd_log_debug(" Diameter message (%p) DUMP:", *diam_fw);
-                fd_msg_dump_walk(0, *diam_fw);
+                char * buf = NULL; size_t buflen;
+                CHECK_MALLOC( fd_msg_dump_treeview(&buf, &buflen, NULL, *diam_fw, NULL, 0, 1) );
+                fd_log_debug(" Diameter message (%p) DUMP: %s", *diam_fw, buf);
+                free(buf);
         }
         
@@ -114 +116 @@
                 fd_log_debug(" Diameter message: NULL pointer");
         } else {
-                fd_log_debug(" Diameter message (%p) DUMP:", *diam_ans);
-                fd_msg_dump_walk(0, *diam_ans);
+                char * buf = NULL; size_t buflen;
+                CHECK_MALLOC( fd_msg_dump_treeview(&buf, &buflen, NULL, *diam_ans, NULL, 0, 1) );
+                fd_log_debug(" Diameter message (%p) DUMP: %s", *diam_ans, buf);
+                free(buf);
         }
         

extensions/app_radgw/rgwx_echodrop.c

@@ -62 +62 @@
                 CHECK_MALLOC_DO( fd_dump_extend( FD_DUMP_STD_PARAMS, "\n"), return NULL);
         }
+        return *buf;
 }
 

extensions/app_radgw/rgwx_sip.c

@@ -723 +723 @@
         struct avp_hdr *ahdr;
         //char buf[254]; /* to store some attributes values (with final '\0') */
-        unsigned char * req_sip = NULL;
         struct session * sess;
         os0_t sid = NULL;