Changeset 233:87ca7b66a90c in freeDiameter

Timestamp:

Mar 4, 2010, 5:24:31 PM (14 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Make the CEA broadcast optional

File:

• freeDiameter/p_ce.c (modified) (2 diffs)

freeDiameter/p_ce.c

@@ -38 +38 @@
 /* This file contains code to handle Capabilities Exchange messages (CER and CEA) and election process */
 
+/* Compilation option:
+ USE_CEA_BROADCAST
+        Define this to enable sending multiple copies of the CEA in case of SCTP connection.
+        This avoids a race condition when sending an application message over a different stream
+        than the CEA, it might be delivered first and thus ignored.
+*/
+
 /* Save a connection as peer's principal */
 static int set_peer_cnx(struct fd_peer * peer, struct cnxctx **cnx)
@@ -813 +820 @@
         CHECK_FCT( fd_msg_rescode_set(msg, "DIAMETER_SUCCESS", NULL, NULL, 0 ) );
         CHECK_FCT( add_CE_info(msg, peer->p_cnxctx, isi & PI_SEC_TLS_OLD, isi & PI_SEC_NONE) );
+#ifdef USE_CEA_BROADCAST
         CHECK_FCT( fd_out_send(&msg, peer->p_cnxctx, peer, (isi & PI_SEC_TLS_OLD) ? FD_CNX_ORDERED : FD_CNX_BROADCAST) ); /* Broadcast in order to avoid further messages sent over a different stream be delivered first... */
+#else /* USE_CEA_BROADCAST */
+        CHECK_FCT( fd_out_send(&msg, peer->p_cnxctx, peer, FD_CNX_ORDERED ) );
+#endif /* USE_CEA_BROADCAST */
         
         /* Handshake if needed */