Changeset 1198:8c4dd4b693c6 in freeDiameter for libfdcore/tcp.c

Timestamp:

Jun 13, 2013, 6:30:14 PM (11 years ago)

Author:

Sebastien Decugis <sdecugis@freediameter.net>

Branch:

default

Phase:

public

Message:

Some cleanups in the traces

File:

• libfdcore/tcp.c (modified) (3 diffs)

libfdcore/tcp.c

@@ -124 +124 @@
         int ret = 0;
         int s;
-        char * buf = NULL; size_t len = 0;
         
         TRACE_ENTRY("%p %p %d", sock, sa, salen);
@@ -138 +137 @@
         pthread_cleanup_push(fd_cleanup_socket, &s);
         
-        LOG_D( "Attempting TCP connection to %s...", fd_sa_dump(&buf, &len, NULL, sa, NI_NUMERICHOST | NI_NUMERICSERV)?:"<error>" );
-        free(buf);
-        
         /* Try connecting to the remote address */
         ret = connect(s, sa, salen);
@@ -147 +143 @@
         
         if (ret < 0) {
-                int lvl;
-                switch (ret = errno) {
-                        case ECONNREFUSED:
-                        
-                                /* "Normal" errors */
-                                lvl = FULL;
-                                break;
-                        default:
-                                lvl = INFO;
-                }
-                /* Some errors are expected, we log at different level */
-                TRACE_DEBUG( lvl, "connect returned an error: %s", strerror(ret));
+                ret = errno;
+                LOG_A( "connect returned an error: %s", strerror(ret));
                 CHECK_SYS_DO( close(s), /* continue */ );
                 *sock = -1;