Changeset 1485:a0ca9ac32a3a in freeDiameter for extensions/dict_dcca_3gpp/dict_dcca_3gpp.c

Timestamp:

Mar 27, 2020, 8:05:54 AM (4 years ago)

Author:

Luke Mewburn <luke@mewburn.net>

Branch:

default

Phase:

public

Message:

dict_dcca_3gpp: more comment improvements

Don't bother with comments for AVPs in tables that are
referenced from other sources.

Add comment explicitly describing AVP renames.

File:

• extensions/dict_dcca_3gpp/dict_dcca_3gpp.c (modified) (5 diffs)

extensions/dict_dcca_3gpp/dict_dcca_3gpp.c

@@ -1408 +1408 @@
         /*==================================================================*/
         /* 3GPP TS 29.140 Table 6.3.1: Diameter MM10 Application AVPs       */
+        /*                                                                  */
+        /* Note: AVPs referenced from other sources are not added here.     */
         /*==================================================================*/
 
@@ -1423 +1425 @@
         };
 
-        /* Note: Uses 3GPP TS 29.329 MSISDN (701).                          */
-
         /* VASP-ID, UTF8String, code 1101, section 6.3.3                    */
         {
@@ -1467 +1467 @@
         };
 
-        /* Note: Uses 3GPP TS 29.061 3GPP-IMSI (1).                         */
-
         /* Sender-Address, UTF8String, code 1104, section 6.3.7             */
         {
@@ -1509 +1507 @@
 
         /* Note: Name conflict with 3GPP TS 32.329 Sequence-Number (716).   */
+        /* Sequence-Number (1107) renamed to Sequence-Number-29.140 (1107). */
         /* Sequence-Number-29.140, Unsigned32, code 1107, section 6.3.10    */
         {
@@ -1523 +1522 @@
 
         /* Note: Name conflict with 3GPP TS 32.299 Recipient-Address (1201). */
+        /* Recipient-Address (1108) renamed to Recipient-Address-29.140 (1108). */
         /* Recipient-Address-29.140, UTF8String, code 1108, section 6.3.11  */
         {