Changeset 691:78b665400097 in freeDiameter for libfdcore/tcp.c

Timestamp:

Jan 20, 2011, 7:44:27 PM (13 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Cleanup all pthread_cleanup_push / pop pairs so that pop is always called after push, or ASSERT(0) is some grave errors

File:

• libfdcore/tcp.c (modified) (1 diff)

libfdcore/tcp.c

@@ -134 +134 @@
         CHECK_SYS(  s = socket(sa->sa_family, SOCK_STREAM, IPPROTO_TCP)  );
         
+        /* Set the socket options */
+        CHECK_FCT(  fd_tcp_setsockopt(sa->sa_family, s)  );
+        
         /* Cleanup if we are cancelled */
         pthread_cleanup_push(fd_cleanup_socket, &s);
-        
-        /* Set the socket options */
-        CHECK_FCT(  fd_tcp_setsockopt(sa->sa_family, s)  );
         
         TRACE_DEBUG_sSA(FULL, "Attempting TCP connection with peer: ", sa, NI_NUMERICHOST | NI_NUMERICSERV, "..." );