Changeset 706:4ffbc9f1e922 in freeDiameter for libfdcore/p_expiry.c

Timestamp:

Feb 9, 2011, 3:26:58 PM (13 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

Large UNTESTED commit with the following changes:

• Improved DiameterIdentity? handling (esp. interationalization issues), and improve efficiency of some string operations in peers, sessions, and dictionary modules (closes #7)
• Cleanup in the session module to free only unreferenced sessions (#16)
• Removed fd_cpu_flush_cache(), replaced by more robust alternatives.
• Improved peer state machine algorithm to counter SCTP multistream race condition.

File:

• libfdcore/p_expiry.c (modified) (4 diffs)

libfdcore/p_expiry.c

@@ -59 +59 @@
                 
                 for (li = fd_g_peers.next; li != &fd_g_peers; li = li->next) {
-                        struct fd_peer * peer = (struct fd_peer *)li;
-                        
-                        fd_cpu_flush_cache();
-                        if (peer->p_hdr.info.runtime.pir_state != STATE_ZOMBIE)
+                        struct fd_peer * peer = (struct fd_peer *)li->o;
+                        
+                        if (fd_peer_getstate(peer) != STATE_ZOMBIE)
                                 continue;
                         
@@ -78 +77 @@
                 /* Now delete peers that are in the purge list */
                 while (!FD_IS_LIST_EMPTY(&purge)) {
-                        struct fd_peer * peer = (struct fd_peer *)(purge.next);
+                        struct fd_peer * peer = (struct fd_peer *)(purge.next->o);
                         fd_list_unlink(&peer->p_hdr.chain);
                         TRACE_DEBUG(INFO, "Garbage Collect: delete zombie peer '%s'", peer->p_hdr.info.pi_diamid);
@@ -105 +104 @@
                 struct fd_peer * first;
                 
-                /* Check if there are expiring sessions available */
+                /* Check if there are expiring peers available */
                 if (FD_IS_LIST_EMPTY(&exp_list)) {
                         /* Just wait for a change or cancelation */
@@ -183 +182 @@
                 
                 /* update the p_exp_timer value */
-                CHECK_SYS(  clock_gettime(CLOCK_REALTIME, &peer->p_exp_timer)  );
+                CHECK_SYS_DO(  clock_gettime(CLOCK_REALTIME, &peer->p_exp_timer), { ASSERT(0); }  );
                 peer->p_exp_timer.tv_sec += peer->p_hdr.info.config.pic_lft;