Changeset 730:e21d79595045 in freeDiameter for libfdproto/messages.c

Timestamp:

Feb 24, 2011, 5:19:42 PM (13 years ago)

Author:

Sebastien Decugis <sdecugis@nict.go.jp>

Branch:

default

Phase:

public

Message:

minor improvements

File:

• libfdproto/messages.c (modified) (1 diff)

libfdproto/messages.c

@@ -1218 +1218 @@
         memcpy(&avp->avp_storage, value, sizeof(union avp_value));
         
-        /* Copy an octetstring if needed. */
+        /* Duplicate an octetstring if needed. */
         if (type == AVP_TYPE_OCTETSTRING) {
                 if (value->os.len) {
-                        CHECK_MALLOC(  avp->avp_storage.os.data = malloc(value->os.len)  );
+                        CHECK_MALLOC(  avp->avp_storage.os.data = os0dup(value->os.data, value->os.len)  );
                         avp->avp_mustfreeos = 1;
-                        memcpy(avp->avp_storage.os.data, value->os.data, value->os.len);
                 } else {
                         avp->avp_storage.os.data = NULL;