Changeset 996:cf09fde3d7f5 in freeDiameter for extensions/app_radgw/rgw_worker.c

Timestamp:

Mar 20, 2013, 12:13:14 AM (11 years ago)

Author:

Sebastien Decugis <sdecugis@freediameter.net>

Branch:

default

Children:

997:632913581c37, 998:ad6c1ee04d2d

Phase:

public

Message:

Fix management of sessions in app_radgw: sessions are simply associated with messages, that is sufficient

File:

• extensions/app_radgw/rgw_worker.c (modified) (10 diffs)

extensions/app_radgw/rgw_worker.c

@@ -54 +54 @@
         struct rgw_radius_msg_meta * rad;  /* the RADIUS message that was received and translated */
         struct rgw_client          * cli;  /* the client it was received from */
-        struct session             * sess; /* the Diameter session created for this message (useful?) */
 };
 
@@ -76 +75 @@
                 struct rgw_radius_msg_meta * msg;
                 struct rgw_client * cli;
-                struct session * session;
                 struct msg * diam_msg;
                 int pb, a;
@@ -133 +131 @@
                         }  );
                 
-                session = NULL;
-                
                 /* Pass the message to the list of registered plugins */
-                CHECK_FCT_DO( rgw_plg_loop_req(&msg, &session, &diam_msg, cli), 
+                CHECK_FCT_DO( rgw_plg_loop_req(&msg, &diam_msg, cli), 
                         {
                                 /* An error occurred, discard message */
@@ -142 +138 @@
                                         CHECK_FCT_DO( fd_msg_free(diam_msg), );
                                         diam_msg = NULL;
-                                }
-                                if (session) {
-                                        CHECK_FCT_DO( fd_sess_destroy(&session), );
                                 }
                                 rgw_msg_free(&msg);
@@ -181 +174 @@
                 if (pb) {
                         /* Something went wrong during the conversion */
-                        if (session) {
-                                CHECK_FCT_DO( fd_sess_destroy(&session), );
-                        }
-                        
                         if (diam_msg) {
                                 CHECK_FCT_DO( fd_msg_free(diam_msg), );
@@ -202 +191 @@
                 pa->rad = msg;
                 pa->cli = cli;
-                pa->sess= session;
                 
                 CHECK_FCT_DO( fd_msg_send( &diam_msg, receive_diam_answer, pa), 
@@ -208 +196 @@
                                 /* If an error occurs, log and destroy the data */
                                 fd_log_debug("An error occurred while sending Diameter message, please turn Debug on for detail.");
-                                if (session) {
-                                        CHECK_FCT_DO( fd_sess_destroy(&session), );
-                                }
 
                                 if (diam_msg) {
@@ -239 +224 @@
         struct avp_hdr  *ahdr;
         int pb = 0;
-        int keepsession=0;
         
         TRACE_ENTRY("%p %p", pa, ans);
@@ -248 +232 @@
         
         /* Pass the Diameter answer to the same extensions as the request */
-        CHECK_FCT_DO( rgw_plg_loop_ans(pa->rad, pa->sess, ans, &rad_ans, pa->cli, &keepsession), goto out );
+        CHECK_FCT_DO( rgw_plg_loop_ans(pa->rad, ans, &rad_ans, pa->cli), goto out );
 
         if (*ans != NULL) {
@@ -300 +284 @@
         }
         
-        if (!keepsession) {
-                /* Destroy remaining session data (stateless gateway) */
-                CHECK_FCT_DO( fd_sess_destroy(&pa->sess),  );
-        }
-        
         /* Clear the RADIUS request */
         if (pa->rad) {