Mercurial > hg > freeDiameter
changeset 1233:0b4abb03bcaf
Fix double increment when realloc resulting in invalid SQL query
| author | Sebastien Decugis <sdecugis@freediameter.net> |
|---|---|
| date | Wed, 04 Sep 2013 02:14:31 +0200 |
| parents | 9e92fa478c23 |
| children | 0b240b3a7320 |
| files | extensions/app_acct/acct_db.c |
| diffstat | 1 files changed, 4 insertions(+), 2 deletions(-) [+] |
line wrap: on
line diff
--- a/extensions/app_acct/acct_db.c Sun Aug 11 11:52:36 2013 +0200 +++ b/extensions/app_acct/acct_db.c Wed Sep 04 02:14:31 2013 +0200 @@ -174,7 +174,8 @@ ADD_EXTEND("\") VALUES ("); if (acct_config->tsfield) { - ADD_EXTEND("$%d, ", ++idx); + ++idx; + ADD_EXTEND("$%d, ", idx); } if (acct_config->srvnfield) { ADD_EXTEND("'"); @@ -184,7 +185,8 @@ for (li = emptyrecords.all.next; li != &emptyrecords.all; li = li->next) { struct acct_record_item * i = (struct acct_record_item *)(li->o); - ADD_EXTEND("$%d::%s", ++idx, diam2db_types_mapping[i->param->avptype]); + ++idx; + ADD_EXTEND("$%d::%s", idx, diam2db_types_mapping[i->param->avptype]); if (li->next != &emptyrecords.all) { ADD_EXTEND(", ");