Mercurial > hg > freeDiameter
changeset 1443:ca7ca55e2488
app_sip: debug log a non-NULL value
Detected by gcc 9.1.1.
| author | Luke Mewburn <luke@mewburn.net> |
|---|---|
| date | Thu, 27 Feb 2020 16:27:48 +1100 |
| parents | 915450ee91c7 |
| children | ab7cb954f17e |
| files | extensions/app_sip/TODO extensions/app_sip/multimediaauth.c |
| diffstat | 2 files changed, 5 insertions(+), 1 deletions(-) [+] |
line wrap: on
line diff
--- a/extensions/app_sip/TODO Thu Feb 27 16:19:24 2020 +1100 +++ b/extensions/app_sip/TODO Thu Feb 27 16:27:48 2020 +1100 @@ -49,6 +49,10 @@ * add mutex on mysql writing * check multithreading of mysql! * get destination host in database for RTR and PPR +* libapp_sip.c: fix username_pure memory leaks +* app_sip_MAR_cb: + - too much mysql_real_escape_string() use, both within the function and functions it calls + - on error, leaks allocated: sipuri, username, query.
--- a/extensions/app_sip/multimediaauth.c Thu Feb 27 16:19:24 2020 +1100 +++ b/extensions/app_sip/multimediaauth.c Thu Feb 27 16:27:48 2020 +1100 @@ -148,7 +148,7 @@ if(not_found) { - TRACE_DEBUG(FULL,"The user %s doesn't exist!",username); + TRACE_DEBUG(FULL,"The user %s doesn't exist!", avphdr->avp_value->os.data); result="DIAMETER_ERROR_USER_UNKNOWN"; free(username); goto out;